Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDHPAI-493: New Developer Sandbox RHDH Internal Plugin #409

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

RHDHPAI-493: New Developer Sandbox RHDH Internal Plugin #409

wants to merge 4 commits into from

Conversation

Lucifergene
Copy link

@Lucifergene Lucifergene commented Feb 12, 2025 •
edited
Loading

Developer Sandbox RHDH Internal Plugin

Screenshots

image

image

Video

Tab-2-19-2025_23_50.1.mp4

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@Lucifergene
added sandbox-plugin
56f9efd 
Signed-off-by: Lucifergene <[email protected]>
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Feb 12, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-sandbox workspaces/sandbox/plugins/sandbox patch v0.0.1

@Lucifergene
Copy link
Author

/cc @rohitkrai03 @karthikjeeyar @ShiranHi

christoph-jerolimov
christoph-jerolimov reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, also if I wasn't asked I quickly looked into this. Nice work 👍

I just like to recommend to use Material UI v4 or MUI v5, not both. You can do it and Backstage core components still use MUI v4. But I would avoid mixing them. :)

All our other other plugins uses MUI v5. Also not v6. It might work, but it could also result in issues when running later as a dynamic plugin in RHDH because RHDH dynamic plugins handles MUI as a shared library. So I guess you will get MUI v5 at runtime. 🤷‍♂️

But at the end, its up to you. The screenshot looks really nice. 😏

@Lucifergene
fixed review comments
436b964 
Signed-off-by: Lucifergene <[email protected]>
@Lucifergene
updated ui to latest ux
cf08c06 
Signed-off-by: Lucifergene <[email protected]>
@ShiranHi
Copy link

ShiranHi commented Feb 20, 2025 •
edited
Loading

Thanks, @Lucifergene , It looks great!

I have a few questions:

Home Page (design):

  1. Can we make the card layout responsive so that if the screen is wide, users will see more cards per row?
  2. Can you also display the tooltip "Product you tried"?
image01
  1. I noticed that all cards initially have the "Product you tried" badge. Just to confirm, this badge should not appear by default, it should only be displayed when a user clicks the "Try it" button. Is this the current behavior?

Mobile Verification Modal (design):

  1. There's an icon in the phone number field, what is it?
image02
  1. Can we pre-select the phone number field so users can start typing immediately when the modal opens?
  2. Can we format the phone number input to display the phone layout, for example: +34 (000) 000 0000?
  3. Can we disable the "Send code" button until a user enters a valid phone number?
  4. The country dropdown appears too high, can we make it open below the field and limit the height to display a maximum of seven countries at once?

Verification Code Modal (design):

  1. Can we disable the "Start trial" button and only enable it once the user has entered the code?
  2. Do we show an error message if the code is invalid?

Access Code Modal (design):

  1. Same as above, can we disable the "Start trial" button until the user has entered the access code?
  2. Do we show an error message if the code is invalid?
  3. I think we need to remove the footer once a valid access code has been entered...

Dark Mode:

  1. Can we adjust the badge color to be a darker cyan #009596 only for the dark mode? It seems too bright.
  2. Can the banner background (where the "Try Red Hat products" title appears) match the header's color?
  3. I noticed that the cards on the Home page and Activity page look different, can we align them to match the Home page style?

Activities Page (design):

  1. We should split the content there, so we have the top "Featured" and the bottom (which gray background) all the rest of the cards.
  2. Can we make the whole card clickable?

@Lucifergene
updated UI
3b313c5 
Signed-off-by: Lucifergene <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov left review comments

@BethGriggs BethGriggs Awaiting requested review from BethGriggs BethGriggs is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner

@kim-tsao kim-tsao Awaiting requested review from kim-tsao kim-tsao is a code owner

@04kash 04kash Awaiting requested review from 04kash 04kash is a code owner

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

@ShiranHi ShiranHi Awaiting requested review from ShiranHi

@coreydaley coreydaley Awaiting requested review from coreydaley coreydaley is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lucifergene @ShiranHi @christoph-jerolimov